feat(workflow): freeze contracts + rename thinking→effort#94
Conversation
Add workflow-types contract module (statuses, AgentOpts, journal shapes, cache key helper, budget stub, concurrency). Wire test into package.json. Fix primitives-spec §13: isolation worktree is v1 must-have. Co-Authored-By: Claude <noreply@anthropic.com>
Normalize LocalAgentRunInput, profiles, CLI, store, and adapters on effort. CLI accepts --thinking as a one-release alias; profile YAML thinking: still maps to effort. DB migration v4 renames the column. Co-Authored-By: Claude <noreply@anthropic.com>
Update profile schema, examples, and subagent skill for effort. Note legacy thinking alias and provider-native pi --thinking flag. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| /** | ||
| * Public agent() options. Deliberately no writeMode. | ||
| */ | ||
| export interface AgentOpts { |
There was a problem hiding this comment.
[P1] Before freezing this public contract, please include a way to select configured agent profiles (profile/agentType) or explicitly keep this surface extensible. As written, workflow agents bypass the existing profile registry and can only choose a raw provider/model/effort, so custom reviewer/implementer instructions and tool policies are unavailable.
|
The primitive set is a strong read-oriented MVP, but I do not think the public contract should be called frozen yet. |
1 participant
Summary
workflow-types.ts)thinking→effortacross runtime, adapters, profiles, store, CLIStack
PR1 of 5 (base for the rest)
pr/dw-1-types-effortmainpr/dw-2-store-sandboxpr/dw-3-enginepr/dw-4-cli-workerpr/dw-5-mcp-skillTest plan
npm run typechecknpm test(includesworkflow-types.test.ts+ effort-related agent tests)--effort/effort:(optional--thinkingalias if present)